[Typing][B-49] Add type annotations for python/paddle/base/layer_helper.py
#66639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Jul 27, 2024
python/paddle/base/layer_helper.py
Outdated
| inputs = self.multiple_input(input_param_name) | ||
| if len(inputs) != 1: | ||
| raise f"{self.layer_type} layer only takes one input" | ||
| return inputs[0] | ||
|
|
||
| @property | ||
| def param_attr(self): | ||
| def param_attr(self) -> ParamAttrLike | list[ParamAttrLike]: |
There was a problem hiding this comment.
这里用的 ParamAttrLike 是不是都应该是 ParamAttr？
SigureMo
reviewed
Jul 31, 2024
python/paddle/base/layer_helper.py
Outdated
| inputs = self.multiple_input(input_param_name) | ||
| if len(inputs) != 1: | ||
| raise f"{self.layer_type} layer only takes one input" | ||
| return inputs[0] | ||
|
|
||
| @property | ||
| def param_attr(self): | ||
| def param_attr(self) -> ParamAttr | list[ParamAttr]: |
There was a problem hiding this comment.
这里是不是按理说只会有一个？应该不会出现 list？bias 同
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
类型标注：
-
python/paddle/base/layer_helper.pyRelated links
@SigureMo @megemini